lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags()
From


On 2023/11/3 20:28, Matthew Wilcox wrote:
> On Fri, Nov 03, 2023 at 03:29:05PM +0800, Kefeng Wang wrote:
>> Replace ten compound_head() calls with one page_folio().
>
> This is going to conflict with Gregory Price's work:
>
> https://lore.kernel.org/linux-mm/ZUCD1dsbrFjdZgVv@memverge.com/
>
> Perhaps the two of you can collaborate on a patch series?

Will check this patch.

>
>> u |= kpf_copy_bit(k, KPF_SLAB, PG_slab);
>> - if (PageTail(page) && PageSlab(page))
>> + if (PageTail(page) && folio_test_slab(folio))
>> u |= 1 << KPF_SLAB;
>
> This doesn't make sense ...
>

Yes, after commit dcb351cd095a ("page-flags: define behavior SL*B-
related flags on compound pages"), the slab could not be a tail,
I will drop this line.

\
 
 \ /
  Last update: 2023-11-20 13:47    [W:0.178 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site