Messages in this thread | | | Date | Fri, 3 Nov 2023 01:22:05 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH net] tcp: Fix -Wc23-extensions in tcp_options_write() |
| |
On Tue, Oct 31, 2023 at 01:23:35PM -0700, Nathan Chancellor wrote: > Clang warns (or errors with CONFIG_WERROR=y) when CONFIG_TCP_AO is set: > > net/ipv4/tcp_output.c:663:2: error: label at end of compound statement is a C23 extension [-Werror,-Wc23-extensions] > 663 | } > | ^ > 1 error generated. > > On earlier releases (such as clang-11, the current minimum supported > version for building the kernel) that do not support C23, this was a > hard error unconditionally: > > net/ipv4/tcp_output.c:663:2: error: expected statement > } > ^ > 1 error generated. > > Add a semicolon after the label to create an empty statement, which > resolves the warning or error for all compilers.
Can you please just split the A0 handlig into a separate helper, which shuld make the whole thing a lot cleaner?
| |