Messages in this thread | | | Date | Wed, 29 Nov 2023 15:38:04 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible |
| |
On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > > On j7200, during suspend to ram the soc is powered-off. > > At resume requested irqs shall be restored which is a different behavior > > from other platforms. > > > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
Un-Acked. Your dts patch contradicts this one.
Is the programming model compatible with the existing devices? To be compatible, the existing device only need to support a compatible subset of behaviours. If so, this patch is wrong. If not, then the dts one is.
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |