Messages in this thread | | | Date | Wed, 29 Nov 2023 13:50:54 +0100 | Subject | Re: [PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support | From | Wenjia Zhang <> |
| |
On 24.11.23 15:42, Wen Gu wrote: > The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for > SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by > OS or hypervisor software, comparable to IBM ISM which is based on platform > firmware or hardware. > > With the introduction of virtual ISM, SMCv2.1 makes some updates: > > - Introduce feature bitmask to indicate supplemental features. > - Reserve a range of CHIDs for virtual ISM. > - Support extended GIDs (128 bits) in CLC handshake. > > So this patch set aims to implement these updates in Linux kernel. And it > acts as the first part of SMC-D virtual ISM extension & loopback-ism [1]. > > [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/ > > v2->v1: > - Fix sparse complaint; > - Rebase to the latest net-next; >
It looks good to me. The testing looks good as well. If these comments are worked out, I'd like to give my Reviewed-by for the next version. BTW, for the next version, you need to rebase your kernel.
| |