| Date | Wed, 29 Nov 2023 09:29:24 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [net-next PATCH 04/14] net: phy: at803x: move qca83xx stats out of generic at803x_priv struct |
| |
On Wed, Nov 29, 2023 at 03:12:09AM +0100, Christian Marangi wrote: > +struct qca83xx_priv { > + u64 stats[ARRAY_SIZE(qca83xx_hw_stats)]; > +};
If QCA83xx is going to use an entirely separate private data structure, then it's clearly a separate driver, and it should be separated from this driver. Having two incompatible private data structures in phydev->priv in the same driver is a recipe for future errors, where functions that expect one private data structure may be called when the other private data structure is stored in phydev->priv.
So, if we're going to do this, then the QCA83xx support needs to _first_ be split from this driver.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
|