Messages in this thread | | | Date | Wed, 29 Nov 2023 10:28:25 +0100 | Subject | Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in bindings | From | Krzysztof Kozlowski <> |
| |
On 28/11/2023 12:32, Krishna Kurapati PSSNV wrote: > >> >> So back to my initial proposal, with a slight modification moving >> pwr_event first (e.g. as it is not a wakeup interrupt): >> >> qusb2-: >> >> - const: pwr_event >> - const: qusb2_phy >> - const: ss_phy_irq (optional) >> >> qusb2: >> >> - const: pwr_event >> - const: hs_phy_irq >> - const: qusb2_phy >> - const: ss_phy_irq (optional) >> >> femto-: >> - const: pwr_event >> - const: dp_hs_phy_irq >> - const: dm_hs_phy_irq >> - const: ss_phy_irq (optional) >> >> femto: >> - const: pwr_event >> - const: hs_phy_irq >> - const: dp_hs_phy_irq >> - const: dm_hs_phy_irq >> - const: ss_phy_irq (optional)
I did not follow entire thread and I do not know whether you change the order in existing bindings, but just in case: the entries in existing bindings cannot change the order. That's a strict ABI requirement recently also discussed with Bjorn, because we want to have stable DTB for laptop platforms. If my comment is not relevant, then please ignore.
Best regards, Krzysztof
| |