lkml.org 
[lkml]   [2023]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue
From


在 2023/11/30 11:29, Matthew Wilcox 写道:
> On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote:
>>>> - * If kswapd scans pages marked for immediate
>>>> + * If kswapd scans massive pages marked for immediate
>>> I don't understand why you've added the word "massive". Do you mean
>>> that the pages are large, or that kswapd has scanned a lot of pages?
>> The added "massive" means that there are a large number of pages marked for
>> immediate reclaim on evictable LRUs.
> Then the word "many" communicates your meaning better. "massive" would
> mean that each page is very big, while "many" means that there are a
> lot of pages.
>
> It was foolish to send out a v2 so swiftly. Best wait for someone who's
> familiar with this code to respond to it now that you've clarified what
> you were doing.
Thanks for you suggestions, I will update the newer version patch later.

\
 
 \ /
  Last update: 2023-11-30 04:40    [W:0.036 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site