lkml.org 
[lkml]   [2023]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v14 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing
    From
    On 11/29/2023 03:13, Ma Jun wrote:
    > From: Evan Quan <quanliangl@hotmail.com>
    >
    > The newly added WBRF feature needs this interface for channel
    > width calculation.
    >
    > Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
    > Signed-off-by: Evan Quan <quanliangl@hotmail.com>

    I think the order should be the other way around for these SoB as
    "you're signing off on Evan's work".

    Otherwise LGTM.

    Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
    >
    > --
    > v8->v9:
    > - correct typo(Mhz -> MHz) (Johnson)
    > v13:
    > - Fix the format issue (IIpo Jarvinen)
    > ---
    > include/net/cfg80211.h | 9 +++++++++
    > net/wireless/chan.c | 3 ++-
    > 2 files changed, 11 insertions(+), 1 deletion(-)
    >
    > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
    > index b137a33a1b68..08f0d7184167 100644
    > --- a/include/net/cfg80211.h
    > +++ b/include/net/cfg80211.h
    > @@ -976,6 +976,15 @@ const struct cfg80211_chan_def *
    > cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1,
    > const struct cfg80211_chan_def *chandef2);
    >
    > +/**
    > + * nl80211_chan_width_to_mhz - get the channel width in MHz
    > + * @chan_width: the channel width from &enum nl80211_chan_width
    > + *
    > + * Return: channel width in MHz if the chan_width from &enum nl80211_chan_width
    > + * is valid. -1 otherwise.
    > + */
    > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width);
    > +
    > /**
    > * cfg80211_chandef_valid - check if a channel definition is valid
    > * @chandef: the channel definition to check
    > diff --git a/net/wireless/chan.c b/net/wireless/chan.c
    > index 2d21e423abdb..dfb4893421d7 100644
    > --- a/net/wireless/chan.c
    > +++ b/net/wireless/chan.c
    > @@ -141,7 +141,7 @@ static bool cfg80211_edmg_chandef_valid(const struct cfg80211_chan_def *chandef)
    > return true;
    > }
    >
    > -static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
    > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
    > {
    > int mhz;
    >
    > @@ -190,6 +190,7 @@ static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
    > }
    > return mhz;
    > }
    > +EXPORT_SYMBOL(nl80211_chan_width_to_mhz);
    >
    > static int cfg80211_chandef_get_width(const struct cfg80211_chan_def *c)
    > {

    \
     
     \ /
      Last update: 2023-11-29 18:27    [W:4.771 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site