Messages in this thread | | | From | Eric Dumazet <> | Date | Wed, 29 Nov 2023 18:02:03 +0100 | Subject | Re: [PATCH v4 2/7] net/tcp: Consistently align TCP-AO option in the header |
| |
On Wed, Nov 29, 2023 at 5:57 PM Dmitry Safonov <dima@arista.com> wrote: > > Currently functions that pre-calculate TCP header options length use > unaligned TCP-AO header + MAC-length for skb reservation. > And the functions that actually write TCP-AO options into skb do align > the header. Nothing good can come out of this for ((maclen % 4) != 0). > > Provide tcp_ao_len_aligned() helper and use it everywhere for TCP > header options space calculations. > > Fixes: 1e03d32bea8e ("net/tcp: Add TCP-AO sign to outgoing packets") > Signed-off-by: Dmitry Safonov <dima@arista.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
| |