Messages in this thread | | | Date | Tue, 28 Nov 2023 15:07:43 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH 07/10] printk: Remove the now superfluous sentinel elements from ctl_table array |
| |
On Tue 2023-11-07 14:45:07, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > rm sentinel element from printk_sysctls > > Signed-off-by: Joel Granados <j.granados@samsung.com>
I am a bit sceptical if the size and time reduction is worth the effort. I feel that this change makes the access a bit less secure.
Well, almost all arrays are static so that it should just work. The patch does what it says. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |