lkml.org 
[lkml]   [2023]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/11] mm/mempolicy: swap cond reference counting logic in do_get_mempolicy
On Wed 22-11-23 16:11:51, Gregory Price wrote:
[...]
> @@ -982,11 +991,11 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask,
> }
>
> out:
> - mpol_cond_put(pol);
> + mpol_put(pol);
> if (vma)
> mmap_read_unlock(mm);
> if (pol_refcount)
> - mpol_put(pol_refcount);
> + mpol_cond_put(pol_refcount);

Maybe I am just misreading the patch but pol_refcount should be always
NULL with this patch

> return err;
> }
>
> --
> 2.39.1
>

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2023-11-28 15:07    [W:0.098 / U:3.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site