lkml.org 
[lkml]   [2023]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param()
    From


    On 11/23/2023 2:16 PM, Can Guo wrote:
    > In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to
    > PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line
    > of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only
    > used here.
    >
    > Signed-off-by: Can Guo <quic_cang@quicinc.com>
    > ---
    > drivers/ufs/host/ufs-qcom.c | 1 -
    > drivers/ufs/host/ufs-qcom.h | 2 --
    > 2 files changed, 3 deletions(-)
    >
    > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
    > index aee66a3..cc30ad9 100644
    > --- a/drivers/ufs/host/ufs-qcom.c
    > +++ b/drivers/ufs/host/ufs-qcom.c
    > @@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
    > switch (status) {
    > case PRE_CHANGE:
    > ufshcd_init_host_param(&host_params);
    > - host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE;
    >
    > /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */
    > host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba);
    > diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h
    > index 9950a00..82cd143 100644
    > --- a/drivers/ufs/host/ufs-qcom.h
    > +++ b/drivers/ufs/host/ufs-qcom.h
    > @@ -27,8 +27,6 @@
    > #define SLOW 1
    > #define FAST 2
    >
    > -#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B
    > -
    > /* QCOM UFS host controller vendor specific registers */
    > enum {
    > REG_UFS_SYS1CLK_1US = 0xC0,

    Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>

    \
     
     \ /
      Last update: 2023-11-28 06:17    [W:2.178 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site