Messages in this thread | | | Date | Tue, 28 Nov 2023 11:26:55 +0100 | Subject | Re: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond | From | Przemek Kitszel <> |
| |
On 11/28/23 08:37, Jiri Pirko wrote: > Mon, Nov 27, 2023 at 05:23:55PM CET, sachin.bahadur@intel.com wrote: >> >>> Nack. Remove the netdev during re-init, that would solve your issue. >>> Looks like some checks are needed to be added in devlink code to make sure >>> drivers behave properly. I'm on in. >> >> Sure. This fix should apply to all drivers. Adding it in devlink makes more >> sense. I am not a devlink expert, so I hope you or someone else can >> help with it. > > No, you misunderstood. I'll just add a check-warn in devlink for case > when port exists during reload. You need to fix it in your driver.
Having a message in log that reminds devs would be useful, thanks!
> >> >>> >>> >>>> + return -EBUSY; >>>> + } >>>> ice_unload(pf); >>>> return 0; >>>> case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: >>>> -- >>>> 2.25.1 >>>> >>>> >
| |