Messages in this thread | | | Date | Tue, 28 Nov 2023 00:19:23 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] xfs: ensure tmp_logflags is initialized in xfs_bmap_del_extent_real |
| |
On Tue, Nov 28, 2023 at 01:32:01PM +0800, Jiachen Zhang wrote: > In the case of returning -ENOSPC, ensure tmp_logflags is initialized by 0. > Otherwise the caller __xfs_bunmapi will set uninitialized illegal > tmp_logflags value into xfs log, which might cause unpredictable error > in the log recovery procedure.
This looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I wonder if removing the local flags variable and always directly assigning to *logflagsp might be more robust in the long run.
| |