Messages in this thread | | | Date | Tue, 28 Nov 2023 08:14:07 +0000 | Subject | Re: [PATCH] mtd: spi-nor: stop printing superfluous debug info | From | Tudor Ambarus <> |
| |
On 11/27/23 17:15, Miquel Raynal wrote: > Hi Tudor, >
Hi!
> tudor.ambarus@linaro.org wrote on Mon, 27 Nov 2023 16:59:08 +0000: > >> The mtd data can be obtain with the mtd ioctls and the SPI NOR >> flash name can be determined interrogating the sysfs entries. >> Stop polluting the kernel log. > > Actually I like these prints when developing/fixing stuff, it's a clear > indication of what's been discovered that is available even if for some > reason my rootfs is not available (which is common when the rootfs is > on a spi-nor). > > So I would not trash all these lines personally... I believe the
What do you find useful about these prints? Maybe you mean that you'd like some indicator that the SPI NOR probed successfully? How abut adding a debug message at the end of mtd_device_register(), or otherwise after mtd_device_register() is called?
> dev_info can be lowered if you prefer, but dev_dbg is already meant for > debugging purposes and will anyway be discarded by default.
Yes, if we're going to keep these sort of prints I think we should definitely lower them from info to dbg. It will speed the boot time and stop polluting the kernel log.
Cheers, ta
| |