Messages in this thread | | | Date | Tue, 28 Nov 2023 08:07:37 +0000 | From | Greg KH <> | Subject | Re: [PATCH v2] usb: typec: class: fix typec_altmode_put_partner to put plugs |
| |
On Mon, Nov 27, 2023 at 09:09:52PM +0000, RD Babiera wrote: > When typec_altmode_put_partner is called by a plug altmode upon release, > the port altmode the plug belongs to will not remove its reference to the > plug. The check to see if the altmode being released evaluates against the > released altmode's partner instead of the calling altmode itself, so change > adev in typec_altmode_put_partner to properly refer to the altmode being > released. > > typec_altmode_set_partner is not run for port altmodes, so also add a check > in typec_altmode_release to prevent typec_altmode_put_partner() calls on > port altmode release. > > --- > Changes since v1: > * Changed commit message for clarity > * Added check to typec_altmode_release to only call put_partner if altmode > belongs to port partner or plug > ---
This info all goes below the following lines:
> > Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes") > Cc: stable@vger.kernel.org > Signed-off-by: RD Babiera <rdbabiera@google.com> > ---
Down here, otherwise if you try to apply this patch, your signed-off-by lines are removed from the patch, right?
As-is, this can not be applied at all :(
Please fix up, thanks.
greg k-h
| |