Messages in this thread | | | From | Subbaraya Sundeep Bhatta <> | Subject | RE: [EXT] Re: [PATCH net] octeontx2-pf: Add missing mutex lock in otx2_get_pauseparam | Date | Wed, 29 Nov 2023 04:55:14 +0000 |
| |
Hi Simon,
>-----Original Message----- >From: Simon Horman <horms@kernel.org> >Sent: Tuesday, November 28, 2023 10:51 PM >To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com> >Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org; >davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil >Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula ><gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com> >Subject: [EXT] Re: [PATCH net] octeontx2-pf: Add missing mutex lock in >otx2_get_pauseparam > >---------------------------------------------------------------------- >On Sat, Nov 25, 2023 at 10:05:41PM +0530, Subbaraya Sundeep wrote: >> All the mailbox messages sent to AF needs to be guarded by mutex lock. >> Add the missing lock in otx2_get_pauseparam function. >> >> Fixes: 75f36270990c ("octeontx2-pf: Support to enable/disable pause >> frames via ethtool") >> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > >Hi, > >I am wondering if the call to otx2_nix_config_bp() in otx2_dcbnl_ieee_setpfc() >also needs to be protected by mbox.lock. > Correct. I will add lock around it and send v2 of this patch.
>And although not strictly related to this patch, while looking over this, I >noticed that in otx2_init_hw_resources() it appears that &mbox->lock may be >unlocked twice in some error paths. > >e.g. > /* Init Auras and pools used by NIX RQ, for free buffer ptrs */ > err = otx2_rq_aura_pool_init(pf); > if (err) { > mutex_unlock(&mbox->lock); > goto err_free_nix_lf; > } > ... >err_free_nix_lf: > mutex_lock(&mbox->lock); > ... > >... Will fix it and send it as another patch.
Thanks, Sundeep
| |