Messages in this thread | | | Date | Tue, 28 Nov 2023 06:26:56 +0100 | Subject | Re: [PATCH v1 3/3] Bluetooth: btnxpuart: remove useless assignment | From | Jiri Slaby <> |
| |
On 27. 11. 23, 20:14, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Remove useless assignment of rx_skb to NULL in case the skb is in error, > this is already done in h4_recv_buf() that is executed a few lines > before.
In case of error, nxpdev->rx_skb contains the error, not NULL, right?
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > drivers/bluetooth/btnxpuart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c > index 951fe3014a3f..b7c56be078f8 100644 > --- a/drivers/bluetooth/btnxpuart.c > +++ b/drivers/bluetooth/btnxpuart.c > @@ -1278,7 +1278,6 @@ static int btnxpuart_receive_buf(struct serdev_device *serdev, const u8 *data, > /* Safe to ignore out-of-sync bootloader signatures */ > if (!is_fw_downloading(nxpdev)) > bt_dev_err(nxpdev->hdev, "Frame reassembly failed (%d)", err); > - nxpdev->rx_skb = NULL;
thanks, -- js suse labs
| |