Messages in this thread | | | Date | Wed, 29 Nov 2023 09:43:24 +0800 | Subject | Re: [PATCH v2 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1 | From | Jacky Huang <> |
| |
Dear Krzysztof,
Thanks for your review.
On 2023/11/28 下午 07:03, Krzysztof Kozlowski wrote: > On 28/11/2023 07:11, Jacky Huang wrote: >> From: Jacky Huang <ychuang3@nuvoton.com> >> > ... > >> >> sys: system-management@40460000 { >> - compatible = "nuvoton,ma35d1-reset"; >> + compatible = "nuvoton,ma35d1-reset", "syscon"; >> reg = <0x0 0x40460000 0x0 0x200>; >> #reset-cells = <1>; >> }; >> @@ -95,6 +96,162 @@ clk: clock-controller@40460200 { >> clocks = <&clk_hxt>; >> }; >> >> + pinctrl: pinctrl@40040000 { >> + compatible = "nuvoton,ma35d1-pinctrl"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + nuvoton,sys = <&sys>; >> + ranges = <0x0 0x0 0x40040000 0xc00>; >> + >> + gpioa: gpio@40040000 { >> + reg = <0x0 0x40>; > Your unit address does not match reg. > > You must test your DTS with `dtbs_check W=1`. > > >> + interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&clk GPA_GATE>; >> + gpio-controller; >> + #gpio-cells = <2>; > > Best regards, > Krzysztof >
"OK, I will fix 'gpioa: gpio@40040000' to 'gpioa: gpio@0', and similarly for gpiob to gpion. I will also eliminate all redundant spaces behind GIC_SPI." Best Regards, Jacky Huang
| |