Messages in this thread | | | Subject | Re: [PATCH v4 2/2] block: warn once for each partition in bio_check_ro() | From | Yu Kuai <> | Date | Wed, 29 Nov 2023 09:13:57 +0800 |
| |
Hi,
在 2023/11/28 21:00, Christoph Hellwig 写道: > On Tue, Nov 28, 2023 at 08:30:27PM +0800, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@huawei.com> >> >> Commit 1b0a151c10a6 ("blk-core: use pr_warn_ratelimited() in >> bio_check_ro()") fix message storm by limit the rate, however, there >> will still be lots of message in the long term. Fix it better by warn >> once for each partition. > > The new field is in the same dword alignment as bd_make_it_fail and > could in theory corrupt it, at least on alpha. I guess we're fine, > because if you enable CONFIG_FAIL_MAKE_REQUEST on alpha you're asking > for this. I still hope we can clean up these non-atomic bools and > replace them with bitops soon.
Yes, I'm working on this, and thanks for the review!
Kuai > > Signed-off-by: Christoph Hellwig <hch@lst.de> > . >
| |