Messages in this thread | | | From | JeeHeng Sia <> | Subject | RE: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string | Date | Tue, 28 Nov 2023 05:24:36 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, November 27, 2023 4:49 PM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com> > Subject: Re: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string > > On 27/11/2023 02:36, Sia Jee Heng wrote: > > Add starfive,jh8100-uart compatible string > > Describe the hardware. Why is it in xilinx? My bad. It should CDNS UART driver. Will fix it. > > Also, missing full stop in each commit msg. Noted. > > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > --- > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Noted. Should I resend the patches with the V1 tag and with addressed comments? > > Best regards, > Krzysztof
| |