Messages in this thread | | | Date | Tue, 28 Nov 2023 21:41:16 +0100 | From | Andreas Kemnade <> | Subject | Re: [PATCH] dt-bindings: clock: ti: Convert interface.txt to json-schema |
| |
Am Tue, 28 Nov 2023 09:41:23 +0100 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>:
[...] > > We have two usecases here (status quo in dts usage and code): > > If these interface clocks are below a ti,clksel then we are > > describing multiple bits in the same register and therefore every > > child of ti,clksel would have the same reg. > > Regs can have bits, so that could still work. > Yes, it could. Things could be designed in another way. But for now I want to get rid of dtbs_check warnings and finally have some fun with that and not always tempted to skip it and just copy over $bad_example. So I am not in the mood of redesigning everything.
> > If the interface clock is not below a ti,clksel then we have reg. > > This should be expressed in the bindings. It's fine to make the reg > optional (skip the description, it's confusing), but the ti,clksel > should reference this schema and enforce it on the children. > Well there are other compatibles below ti,clksel, too, so should we rather add them when the other .txt files are converted?
Regards, Andreas
| |