Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 28 Nov 2023 20:16:18 +0100 | Subject | Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3 |
| |
Hi Javier,
On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > The Imagination Technologies PowerVR Series 6 GPU is currently only > > supported on Texas Instruments K3 AM62x SoCs. Hence add a dependency on > > ARCH_K3, to prevent asking the user about this driver when configuring a > > kernel without Texas Instruments K3 Multicore SoC support. > > > > Fixes: 4babef0708656c54 ("drm/imagination: Add skeleton PowerVR driver") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Indeed. Although I wonder what is the supposed policy since for example > the DRM_PANFROST symbol only depends on ARM || ARM64 and others such as
I think ARM Mali is sufficiently ubiquitous on ARM/ARM64 systems to have just an ARM/ARM64 dependency...
> DRM_ETNAVIV don't even have an SoC or architecture dependency.
Vivante GPUs are found in DTS files on at least 4 architectures. Might be worthwhile to add some dependencies, though...
> In any case, I agree with you that restricting to only K3 makes sense.
I am looking forward to adding || SOC_AM33XX || ARCH_RENESAS || ..., eventually ;-)
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |