Messages in this thread Patch in this message | | | Date | Tue, 28 Nov 2023 14:38:08 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v4 04/53] perf mmap: Lazily initialize zstd streams |
| |
Em Tue, Nov 28, 2023 at 02:14:33PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Nov 27, 2023 at 07:00:06PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Nov 02, 2023 at 10:56:46AM -0700, Ian Rogers escreveu: > > > Zstd streams create dictionaries that can require significant RAM, > > > especially when there is one per-CPU. Tools like perf record won't use > > > the streams without the -z option, and so the creation of the streams > > > is pure overhead. Switch to creating the streams on first use.
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> > Thanks, applied to perf-tools-next.
> Trying to fix this now: > > 6 20.59 alpine:3.18 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10) > In file included from util/zstd.c:5: > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?
So the problem was really the one above, that got fixed with the patch below, that is what 'man size_t' documents on my fedora:38 system.
- Arnaldo
diff --git a/tools/perf/util/compress.h b/tools/perf/util/compress.h index 9eb6eb5bf038ce54..b29109cd36095c4f 100644 --- a/tools/perf/util/compress.h +++ b/tools/perf/util/compress.h @@ -3,7 +3,8 @@ #define PERF_COMPRESS_H #include <stdbool.h> -#include <stdlib.h> +#include <stddef.h> +#include <sys/types.h> #ifdef HAVE_ZSTD_SUPPORT #include <zstd.h> #endif > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~ > | size_t > util/zstd.c:31:9: error: conflicting types for 'zstd_compress_stream_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'long int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous declaration of 'zstd_compress_stream_to_records' with type 'int(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > make[3]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: util] Error 2 > CC /tmp/build/perf/util/zstd.o > CC /tmp/build/perf/util/cap.o > CXX /tmp/build/perf/util/demangle-cxx.o > CC /tmp/build/perf/util/demangle-ocaml.o > In file included from util/zstd.c:5: > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown type name 'ssize_t'; did you mean 'size_t'? > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~ > | size_t > CC /tmp/build/perf/util/demangle-java.o > util/zstd.c:31:9: error: conflicting types for 'zstd_compress_stream_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'long int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous declaration of 'zstd_compress_stream_to_records' with type 'int(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > 7 21.14 alpine:edge : FAIL gcc version 13.1.1 20230722 (Alpine 13.1.1_git20230722) > In file included from util/zstd.c:5: > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown type name 'ssize_t'; did you mean 'size_t'? > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~ > | size_t > util/zstd.c:31:9: error: conflicting types for 'zstd_compress_stream_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'long int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous declaration of 'zstd_compress_stream_to_records' with type 'int(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > make[3]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: util] Error 2 > CC /tmp/build/perf/util/cap.o > CXX /tmp/build/perf/util/demangle-cxx.o > CC /tmp/build/perf/util/demangle-ocaml.o > CC /tmp/build/perf/util/demangle-java.o > In file included from util/zstd.c:5: > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown type name 'ssize_t'; did you mean 'size_t'? > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~ > | size_t > util/zstd.c:31:9: error: conflicting types for 'zstd_compress_stream_to_records'; have 'ssize_t(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'long int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 31 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:9: note: previous declaration of 'zstd_compress_stream_to_records' with type 'int(struct zstd_data *, void *, size_t, void *, size_t, size_t, size_t (*)(void *, size_t))' {aka 'int(struct zstd_data *, void *, long unsigned int, void *, long unsigned int, long unsigned int, long unsigned int (*)(void *, long unsigned int))'} > 34 | ssize_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t dst_size, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >
--
| |