lkml.org 
[lkml]   [2023]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] gpio: sysfs: fix forward declaration of struct gpio_device
    On Mon, Nov 27, 2023 at 8:37 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
    >
    > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    >
    > The forward declaration for struct gpio_device should be provided for
    > both branches of the #ifdef.
    >
    > Fixes: 08a149c40bdb ("gpiolib: Clean up headers")
    > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    > ---
    > drivers/gpio/gpiolib-sysfs.h | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpio/gpiolib-sysfs.h b/drivers/gpio/gpiolib-sysfs.h
    > index 0f213bdb4732..b794b396d6a5 100644
    > --- a/drivers/gpio/gpiolib-sysfs.h
    > +++ b/drivers/gpio/gpiolib-sysfs.h
    > @@ -3,10 +3,10 @@
    > #ifndef GPIOLIB_SYSFS_H
    > #define GPIOLIB_SYSFS_H
    >
    > -#ifdef CONFIG_GPIO_SYSFS
    > -
    > struct gpio_device;
    >
    > +#ifdef CONFIG_GPIO_SYSFS
    > +
    > int gpiochip_sysfs_register(struct gpio_device *gdev);
    > void gpiochip_sysfs_unregister(struct gpio_device *gdev);
    >
    > --
    > 2.40.1
    >

    I applied this. I'll make patch 2/2 part of the upcoming locking rework.

    Bart

    \
     
     \ /
      Last update: 2023-11-28 17:45    [W:6.646 / U:0.900 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site