Messages in this thread | | | Date | Mon, 27 Nov 2023 16:02:22 +0100 | From | Petr Malat <> | Subject | Re: [PATCH 2/2] bootconfig: Apply early options from embedded config |
| |
Hi Masami, On Mon, Nov 27, 2023 at 07:46:30AM +0900, Masami Hiramatsu wrote:
Shortened the mail as this seems to be the last open point
> > > And as I pointed, we can remove CONFIG_BOOT_CONFIG_EMBED_APPEND_INITRD so this case > > > should be removed. > > > > I have added BOOT_CONFIG_EMBED_APPEND_INITRD, because it's not backward > > compatible change and I didn't want to risk breaking current use cases. > > My change tries to get early options working without affecting how > > other options are handled, but I think appending the config is more > > reasonable behavior and if you do not see it as a problem to not be > > backward compatible here, I will delete the "replace" behavior. > > That's a good point. OK if disabling CONFIG_BOOT_CONFIG_EMBED_APPEND_INITRD, > it must skip setting early_params to avoid "hidden setting" from the > embedded bootconfig.
That's not a good idea because then disabling BOOT_CONFIG_EMBED_APPEND_INITRD would disable early options handling even if the user doesn't use initrd at all, which we do not want.
I suggest logging a KERN_NOTICE message if any early option was applied and at the same time embedded bootconfig was replaced. Petr
| |