Messages in this thread | | | Date | Mon, 27 Nov 2023 11:43:03 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/2] perf lock info: Enforce exactly one of --map and --thread |
| |
Em Mon, Nov 13, 2023 at 11:50:16AM +0000, Nick Forrington escreveu: > On 08/11/2023 20:28, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 01, 2023 at 11:00:42PM -0700, Namhyung Kim escreveu: > > > On Wed, Nov 1, 2023 at 7:35 AM Nick Forrington <nick.forrington@arm.com> wrote: > > > > On 31/10/2023 15:38, Arnaldo Carvalho de Melo wrote: > > > > > Em Tue, Oct 31, 2023 at 12:05:25PM +0000, Nick Forrington escreveu: > > > > > > Improve error reporting for command line arguments. > > > > > > Display error/usage if neither --map or --thread are specified (rather > > > > > > than a non user-friendly error "Unknown type of information"). > > > > > > Display error/usage if both --map and --thread are specified (rather > > > > > > than ignoring "--map" and displaying only thread information). > > > > > Shouldn't one of them be the default so that we type less for the most > > > > > common usage? > > > > There isn't an obvious choice (to me) for which would be the default. > > > > Both options display completely different data/outputs, so I think it > > > > makes sense to be explicit about which data is requested. > > > Maybe we can default to display both. :) > > Yeah, that would be a better approach, I think. > I'll submit an updated series for this, with the next update to patch 1/2 Thanks, tried using b4 but it din't find a v2, will wait then.
- Arnaldo
| |