lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RESEND PATCH v7 09/10] selftests/mm/cow: Generalize do_run_with_thp() helper
    From
    >>
    >>> +    pmdsize = read_pmd_pagesize();
    >>> +    if (pmdsize)
    >>> +        ksft_print_msg("[INFO] detected PMD-mapped THP size: %zu KiB\n",
    >>
    >> Maybe simply: "detected PMD size". Zes, we read it via the THP interface, but
    >> that shouldn't matter much.
    >
    > Err, just want to clarify what you are suggesting. With the current patch you
    > will see something like:

    Not with this patch, but with the other ones, yes :)

    >
    > [INFO] detected PMD-mapped THP size: 2048 KiB
    > [INFO] detected small-sized THP size: 64 KiB
    > [INFO] detected small-sized THP size: 128 KiB
    > ...
    > [INFO] detected small-sized THP size: 1024 KiB
    >
    >
    > Are you suggesting something like this:
    >
    > [INFO] detected PMD size: 2048 KiB
    > [INFO] detected THP size: 64 KiB
    > [INFO] detected THP size: 128 KiB
    > ...
    > [INFO] detected THP size: 2048 KiB
    >

    Yes. If you'd detect that 2M is actually disabled, you could still log
    the PMD size only.

    So for this patch only as a preparation

    [INFO] detected PMD size: 2048 KiB
    [INFO] detected THP size: 2048 KiB

    Just a thought.

    --
    Cheers,

    David / dhildenb

    \
     
     \ /
      Last update: 2023-11-27 15:18    [W:3.877 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site