Messages in this thread | | | Date | Mon, 27 Nov 2023 13:43:57 +0000 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 0/3] kernfs: Convert from strlcpy() to strscpy() |
| |
On Thu, Nov 16, 2023 at 11:21:22AM -0800, Kees Cook wrote: > Hi, > > One of the last users of strlcpy() is kernfs, which has some complex > calling hierarchies that needed to be carefully examined. This series > refactors the strlcpy() calls into strscpy() calls, and bubbles up all > changes in return value checking for callers.
Why not work instead to convert kernfs (and by proxy cgroups) to use the "safe" string functions based on seq_file? This should be a simpler patch series to review, and implement on a per-function basis, and then we would not have any string functions in kernfs anymore.
thanks,
greg k-h
| |