Messages in this thread | | | Date | Mon, 27 Nov 2023 14:37:50 +0100 | Subject | Re: [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch | From | AngeloGioacchino Del Regno <> |
| |
Il 27/11/23 08:21, Krzysztof Kozlowski ha scritto: > On 27/11/2023 08:09, Macpaul Lin wrote: >> On 11/25/23 18:37, Krzysztof Kozlowski and Chunfeng Yun wrote: >>> >>> >>> External email : Please do not click links or open attachments until you >>> have verified the sender or the content. >>> >>> On 25/11/2023 02:23, Chunfeng Yun wrote: >>>> Due to some old SoCs with shared t-phy only support force-mode switch, and >>>> can't use compatible to distinguish between shared and non-shared t-phy, >>>> add a property to supported it. >>>> But now prefer to use "mediatek,syscon-type" on new SoC as far as possible.
Two questions: 1. Why is it *not* possible to use the compatible string to distinguish between shared and non-shared T-PHYs? 2. If we really can't use compatibles, what's the reason why we can't use the "mediatek,syscon-type" property?
Regards, Angelo
>>>> >>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >>>> --- >>>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> index 2bb91542e984..eedba5b7025e 100644 >>>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> @@ -235,6 +235,12 @@ patternProperties: >>>> Specify the flag to enable BC1.2 if support it >>>> type: boolean >>>> >>>> + mediatek,force-mode: >>>> + description: >>>> + Use force mode to switch shared phy mode, perfer to use the bellow >>>
| |