lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,hsc030
On Mon, Nov 27, 2023 at 09:06:54AM +0100, Krzysztof Kozlowski wrote:
> On 26/11/2023 11:14, Petre Rodan wrote:
> > + honeywell,pmin-pascal:
> > + description: |
> > + Minimum pressure value the sensor can measure in pascal.
> > + To be specified only if honeywell,pressure-triplet is set to "NA".
> > + $ref: /schemas/types.yaml#/definitions/int32
> > +
> > + honeywell,pmax-pascal:
> > + description: |
> > + Maximum pressure value the sensor can measure in pascal.
> > + To be specified only if honeywell,pressure-triplet is set to "NA".
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Sent a pull request:
> https://github.com/devicetree-org/dt-schema/pull/118
> Once it get merged, both $ref could be dropped.

thank your for the PR.

in patternProperties, please also add the int32 type for pascal.
your patch seems to cover kilopascal only.

cheers,
peter


>
> Best regards,
> Krzysztof
>

--
petre rodan

\
 
 \ /
  Last update: 2023-11-27 13:49    [W:0.036 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site