lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] nfc: llcp_sock_sendmsg: Reformat code to make the smaller block indented
From
On 25/11/2023 21:26, Siddh Raman Pant wrote:
> The block for datagram sending is a significantly bigger chunk of the
> function compared to the other scenario.
>
> Thus, put the significantly smaller block inside the if-block.
>


>
> + if (sk->sk_state != LLCP_BOUND) {
> release_sock(sk);
> -
> - return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap,
> - msg, len);
> + return -ENOTCONN;
> }
>
> - if (sk->sk_state != LLCP_CONNECTED) {
> + DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr, msg->msg_name);

No, this code is not readable. I don't think this change helps in anything.

> +
> + if (msg->msg_namelen < sizeof(*addr)) {
> release_sock(sk);
> - return -ENOTCONN;
> + return -EINVAL;
> }
>
> release_sock(sk);
>
> - return nfc_llcp_send_i_frame(llcp_sock, msg, len);
> + return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap,
> + msg, len);
> +

Stray blank line.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-11-27 11:57    [W:1.472 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site