Messages in this thread | | | Date | Mon, 27 Nov 2023 10:27:40 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH v2] iommu/tegra-smmu: drop error checking for debugfs_create_dir() |
| |
On Wed, Oct 25, 2023 at 05:25:58PM +0200, Dario Binacchi wrote: > The return value of debugfs_create_dir() should be checked using the > IS_ERR() function. The patch, however, drops the check statement without > fixing it because the subsequent functions (i. e. debugfs_create_file()) > can handle the case where `@parent` is an error pointer.
This deserves a comment in the code explaining why no error checking is needed.
Regards,
Joerg
| |