Messages in this thread | | | From | "Zhang, Tina" <> | Subject | RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA | Date | Tue, 28 Nov 2023 00:23:10 +0000 |
| |
> -----Original Message----- > From: Jason Gunthorpe <jgg@nvidia.com> > Sent: Tuesday, November 28, 2023 2:25 AM > To: Zhang, Tina <tina.zhang@intel.com> > Cc: Joerg Roedel <joro@8bytes.org>; iommu@lists.linux.dev; linux- > kernel@vger.kernel.org; David Woodhouse <dwmw2@infradead.org>; Lu > Baolu <baolu.lu@linux.intel.com>; Will Deacon <will@kernel.org>; Robin > Murphy <robin.murphy@arm.com>; Tian, Kevin <kevin.tian@intel.com>; > Nicolin Chen <nicolinc@nvidia.com>; Michael Shavit <mshavit@google.com>; > Vasant Hegde <vasant.hegde@amd.com> > Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA > > On Fri, Oct 27, 2023 at 08:20:13AM -0300, Jason Gunthorpe wrote: > > On Fri, Oct 27, 2023 at 09:14:17AM +0000, Zhang, Tina wrote: > > > > > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote: > > > > > > From: Jason Gunthorpe <jgg@nvidia.com> > > > > > > > > > > > > Linus suggested that the kconfig here is confusing: > > > > > > > > > > While this patch looks decent to me, you forgot to Cc Linus on > > > > > it. In general, given that it touches a couple of core files, > > > > > I'd like to wait for some more people to have a look at it and not rushing > anything in. > > > > Make sense. I'll CC Linus. Comments are welcome. > > > > > Can we separate this patch? I'm thinking about CC more people for > > > review. At least, we need to CC all the reviewers of > > > https://lore.kernel.org/all/20230506133134.1492395-1- > jacob.jun.pan@l > > > inux.intel.com/ to this patch. So, it seems more reasonable to > > > separate this patch. What do you think? > > > > I think that makes sense, let's go ahead with the rest of the SVA > > series and we can do this next cycle. Bikeshedding config names isn't > > really critical. > > So this didn't make it even without the config change :( > > Can you please resend it again and CC the right please please. This needs to go > into this cycle for sure Sure.
Regards, -Tina > > Thanks > Jason
| |