lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v5 14/50] perf thread: Add missing RC_CHK_EQUAL
    From
    Comparing pointers without RC_CHK_ACCESS means the indirect object
    will be compared rather than the underlying maps when REFCNT_CHECKING
    is enabled. Fix by adding missing RC_CHK_EQUAL.

    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    tools/perf/util/thread.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
    index fe5e6991ae4b..b9c2039c4230 100644
    --- a/tools/perf/util/thread.c
    +++ b/tools/perf/util/thread.c
    @@ -385,7 +385,7 @@ static int thread__clone_maps(struct thread *thread, struct thread *parent, bool
    if (thread__pid(thread) == thread__pid(parent))
    return thread__prepare_access(thread);

    - if (thread__maps(thread) == thread__maps(parent)) {
    + if (RC_CHK_EQUAL(thread__maps(thread), thread__maps(parent))) {
    pr_debug("broken map groups on thread %d/%d parent %d/%d\n",
    thread__pid(thread), thread__tid(thread),
    thread__pid(parent), thread__tid(parent));
    --
    2.43.0.rc1.413.gea7ed67945-goog
    \
     
     \ /
      Last update: 2023-11-27 23:12    [W:6.616 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site