Messages in this thread | | | Date | Mon, 27 Nov 2023 21:29:06 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] driver : edac : Fix warning using plain integer as NULL |
| |
On Tue, Nov 28, 2023 at 01:49:06AM +0530, Abhinav Singh wrote:a > Okay, so I guess as of now there is no change needed, so I need not > send a v2 patch, right?
As of now, you should go back and reread the whole thread.
I'm going to give you one last example and then stop:
Imagine one fine day you're doing git archeology, you find the place in the code about which you want to find out why it was changed the way it is now.
You do git annotate <filename> ... find the line, see the commit id and you do:
git show <commit id>
You read the commit message and there's just gibberish and nothing's explaining *why* that change was done. And you start scratching your head, trying to figure out why. Because the damn commit message is worth sh*t.
This happens to us maintainers at least once a week. Well, I don't want that to happen in my tree anymore.
You catch my drift? :)
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |