lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 13/55] media: aspeed: Stop abusing of min_buffers_needed field
    From

    On 11/27/23 10:54, Benjamin Gaignard wrote:
    > 'min_buffers_needed' is suppose to be used to indicate the number
    > of buffers needed by DMA engine to start streaming.
    > aspeed doesn't use DMA engine and just want to specify
    > the minimum number of buffers to allocate when calling VIDIOC_REQBUFS.
    > That 'min_reqbufs_allocation' field purpose so use it.


    Reviewed-by: Eddie James <eajames@linux.ibm.com>


    >
    > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
    > CC: Eddie James <eajames@linux.ibm.com> (maintainer:ASPEED VIDEO ENGINE DRIVER)
    > CC: Joel Stanley <joel@jms.id.au> (supporter:ARM/ASPEED MACHINE SUPPORT)
    > CC: Andrew Jeffery <andrew@codeconstruct.com.au> (reviewer:ARM/ASPEED MACHINE SUPPORT)
    > CC: openbmc@lists.ozlabs.org (moderated list:ASPEED VIDEO ENGINE DRIVER)
    > CC: linux-aspeed@lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE SUPPORT)
    > ---
    > drivers/media/platform/aspeed/aspeed-video.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/platform/aspeed/aspeed-video.c
    > index d08aa7f73d4f..c28b10808cda 100644
    > --- a/drivers/media/platform/aspeed/aspeed-video.c
    > +++ b/drivers/media/platform/aspeed/aspeed-video.c
    > @@ -2034,7 +2034,7 @@ static int aspeed_video_setup_video(struct aspeed_video *video)
    > vbq->drv_priv = video;
    > vbq->buf_struct_size = sizeof(struct aspeed_video_buffer);
    > vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
    > - vbq->min_buffers_needed = ASPEED_VIDEO_V4L2_MIN_BUF_REQ;
    > + vbq->min_reqbufs_allocation = ASPEED_VIDEO_V4L2_MIN_BUF_REQ;
    >
    > rc = vb2_queue_init(vbq);
    > if (rc) {

    \
     
     \ /
      Last update: 2023-11-27 20:28    [W:4.161 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site