lkml.org 
[lkml]   [2023]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver : edac : Fix warning using plain integer as NULL
On Mon, Nov 27, 2023 at 11:53:02PM +0530, Abhinav Singh wrote:
> Hello, thanks for reviewing this. As of now this is only a warning issue in
> kernel. I saw this post by linus
> https://www.spinics.net/lists/linux-sparse/msg10066.html and thought of
> submitting a patch. Also a similar patch of mine got accepted
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2560740.html,
> so thought about opening this one as well.

Lemme try to understand what you're saying: just because someone
accepted a patch of yours, then others should not ask you to improve
your commit message so that it explains *why* a change should be done.

How about you put the gist of what Linus is saying in your commit
message? Don't you think it would be a much better commit message then?

Especially if it explains why, even if it is the case that 0 == NULL, we
don't want those in the kernel.

Hmmm?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2023-11-27 19:40    [W:0.063 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site