Messages in this thread | | | Date | Sat, 25 Nov 2023 12:21:24 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8 |
| |
On Thu, Nov 23, 2023 at 01:42:21PM -0300, Marcelo Schmitt wrote:
> + spi-max-frequency: true
This is not needed, since you have unevaluatedProperties: false & include the spi periph props.
> + adi,conversion-start-gpios: > + description:
> + Device tree identifier of the CONVST pin.
"gpio connected to the CONVST pin".
> + This logic input is used to initiate conversions on the analog > + input channels. > + maxItems: 1
This looks pretty decent to be overall though. [unhandled content-type:application/pgp-signature] | |