lkml.org 
[lkml]   [2023]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8
On Thu, Nov 23, 2023 at 01:42:21PM -0300, Marcelo Schmitt wrote:

> + spi-max-frequency: true

This is not needed, since you have unevaluatedProperties: false &
include the spi periph props.

> + adi,conversion-start-gpios:
> + description:

> + Device tree identifier of the CONVST pin.

"gpio connected to the CONVST pin".

> + This logic input is used to initiate conversions on the analog
> + input channels.
> + maxItems: 1

This looks pretty decent to be overall though.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-11-25 13:22    [W:0.128 / U:22.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site