lkml.org 
[lkml]   [2023]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] riscv: fix __user annotation in traps_misaligned.c
From


On 24/11/2023 11:45, Christoph Hellwig wrote:
> On Fri, Nov 24, 2023 at 11:28:08AM +0100, Clément Léger wrote:
>> I sent a similar patch two days ago with the same modification. I'm not
>> sure to get it. Why is it better to pass the "unsigned long" type from
>> the caller ? I mean, the resulting code would look like this right ?
>
> Because you're legimitizing casting between address_space, which is a
> horrible idea. By casting either from the unsigned long you make it
> very clear that deep magic is coming in and you make an informed
> decisions based on the user_mode() predicate. Witht a blind cast
> to add/remove a __user you don't.

Makes sense indeed, thanks !

Clément

>
> I'm actually surprised sparse even allows __user casts without __force.

\
 
 \ /
  Last update: 2023-11-24 11:47    [W:0.053 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site