Messages in this thread | | | Date | Thu, 23 Nov 2023 17:42:45 +0200 | Subject | Re: [PATCH] mfd: twl4030-power: Revert to use of_match_device() | From | Péter Ujfalusi <> |
| |
On 23/11/2023 12:39, Lee Jones wrote: > On Sun, 29 Oct 2023, Peter Ujfalusi wrote: > >> The core twl chip is probed via i2c and the dev->driver->of_match_table is >> NULL, causing the driver to fail to probe. >> >> This partially reverts commit 1e0c866887f4. >> >> Fixes: 1e0c866887f4 ("mfd: Use device_get_match_data() in a bunch of drivers") >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> >> --- >> drivers/mfd/twl4030-power.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Rob, does this work for you?
This is not needed, twl4030-power is a proper platform device, it should have of_match_data.
I had a boot failure likely caused by something else and I thought this might be part of the puzzle to get it working again.
Sorry for the confusion.
-- Péter
| |