Messages in this thread | | | Subject | Re: [PATCH] EDAC: armada_xp: Explicitly include correct DT includes | From | Jan Lübbe <> | Date | Thu, 23 Nov 2023 13:01:02 +0100 |
| |
On Fri, 2023-10-13 at 14:03 -0500, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Jan Luebbe <jlu@pengutronix.de>
Sorry for the delay, Jan
> --- > drivers/edac/armada_xp_edac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c > index c4bd2fb9c46b..f18db536d58e 100644 > --- a/drivers/edac/armada_xp_edac.c > +++ b/drivers/edac/armada_xp_edac.c > @@ -5,7 +5,9 @@ > > #include <linux/kernel.h> > #include <linux/edac.h> > -#include <linux/of_platform.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/platform_device.h> > > #include <asm/hardware/cache-l2x0.h> > #include <asm/hardware/cache-aurora-l2.h>
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |