Messages in this thread | | | Subject | Re: [PATCH 2/4 net] qca_spi: Fix SPI IRQ handling | From | Paolo Abeni <> | Date | Thu, 23 Nov 2023 12:37:21 +0100 |
| |
On Tue, 2023-11-21 at 17:30 +0100, Stefan Wahren wrote: > The functions qcaspi_netdev_open/close are responsible of request & > free of the SPI interrupt, which wasn't the best choice. Currently > it's possible to trigger a double free of the interrupt by calling > qcaspi_netdev_close() after qcaspi_netdev_open() has failed. > So let us split IRQ allocation & enabling, so we can take advantage > of a device managed IRQ and also fix the issue. > > Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") > Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
The change makes sense, but the changelog is confusing.
qcaspi_netdev_close() and qcaspi_netdev_open() are invoked only via ndo_open and ndo_close(), right? So qcaspi_netdev_close() will never be invoked qcaspi_netdev_open(), failure - that is when IFF_UP is not set.
Cheers,
Paolo
| |