Messages in this thread | | | Date | Thu, 23 Nov 2023 11:58:19 +0100 | Subject | Re: [RFC PATCH 2/2] soundwire: fix initializing sysfs for same devices on different buses | From | Krzysztof Kozlowski <> |
| |
On 17/10/2023 18:09, Pierre-Louis Bossart wrote: > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > If same devices with same device IDs are present on different soundwire > buses, the probe fails due to conflicting device names and sysfs > entries: > > sysfs: cannot create duplicate filename '/bus/soundwire/devices/sdw:0:0217:0204:00:0' > > The link ID is 0 for both devices, so they should be differentiated by > the controller ID. Add the controller ID so, the device names and sysfs entries look > like: > > sdw:1:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6ab0000.soundwire-controller/sdw-master-1-0/sdw:1:0:0217:0204:00:0 > sdw:3:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6b10000.soundwire-controller/sdw-master-3-0/sdw:3:0:0217:0204:00:0 > > [PLB changes: use bus->controller_id instead of bus->id] > > Fixes: 7c3cd189b86d ("soundwire: Add Master registration") > Cc: <stable@vger.kernel.org> > Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> > Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com> > Co-developed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
The order of SoB is not correct. Author's goes before co-developed.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |