Messages in this thread | | | Subject | Re: [PATCH net-next v1 3/3] net: dsa: microchip: Fix PHY loopback configuration for KSZ8794 and KSZ8873 | From | Paolo Abeni <> | Date | Thu, 23 Nov 2023 11:52:57 +0100 |
| |
Hi,
On Tue, 2023-11-21 at 16:24 +0100, Oleksij Rempel wrote: > Correct the PHY loopback bit handling in the ksz8_w_phy_bmcr and > ksz8_r_phy_bmcr functions for KSZ8794 and KSZ8873 variants in the ksz8795 > driver. Previously, the code erroneously used Bit 7 of port register 0xD > for both chip variants, which is actually for LED configuration. This > update ensures the correct registers and bits are used for the PHY > loopback feature: > > - For KSZ8794: Use 0xF / Bit 7. > - For KSZ8873: Use 0xD / Bit 0. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This looks like a bugfix, so possibly worth a Fixes tag? Given the dependency on the previous refactor, I think we can take it via net- next.
@Andrew, Florian, Vladimir: do you have any specific preference here?
Thanks!
Paolo
| |