Messages in this thread | | | From | Kairui Song <> | Date | Thu, 23 Nov 2023 18:51:13 +0800 | Subject | Re: [PATCH 06/24] swap: rework swapin_no_readahead arguments |
| |
Chris Li <chrisl@kernel.org> 于2023年11月21日周二 14:44写道: > > On Sun, Nov 19, 2023 at 11:48 AM Kairui Song <ryncsn@gmail.com> wrote: > > > > From: Kairui Song <kasong@tencent.com> > > > > Make it use alloc_pages_mpol instead of vma_alloc_folio, and accept > > mm_struct directly as an argument instead of taking a vmf as argument. > > Make its arguments similar to swap_{cluster,vma}_readahead, to > > make the code more aligned. > > It is unclear to me what is the value of making the > swap_{cluster,vma}_readahead more aligned here. > > > Also prepare for following commits which will skip vmf for certain > > swapin paths. > > The following patch 07/24 does not seem to use this patch. > Can it merge with the other patch that uses it? > > As it is, this patch does not serve a stand alone value to justify it.
Yes, I'll rearrange this.
| |