Messages in this thread | | | Subject | Re: [net-next PATCH v2] net: phy: correctly check soft_reset ret ONLY if defined for PHY | From | patchwork-bot+netdevbpf@kernel ... | Date | Fri, 24 Nov 2023 01:20:25 +0000 |
| |
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>:
On Tue, 21 Nov 2023 14:53:32 +0100 you wrote: > Introduced by commit 6e2d85ec0559 ("net: phy: Stop with excessive soft > reset"). > > soft_reset call for phy_init_hw had multiple revision across the years > and the implementation goes back to 2014. Originally was a simple call > to write the generic PHY reset BIT, it was then moved to a dedicated > function. It was then added the option for PHY driver to define their > own special way to reset the PHY. Till this change, checking for ret was > correct as it was always filled by either the generic reset or the > custom implementation. This changed tho with commit 6e2d85ec0559 ("net: > phy: Stop with excessive soft reset"), as the generic reset call to PHY > was dropped but the ret check was never made entirely optional and > dependent whether soft_reset was defined for the PHY driver or not. > > [...]
Here is the summary with links: - [net-next,v2] net: phy: correctly check soft_reset ret ONLY if defined for PHY https://git.kernel.org/netdev/net-next/c/aadbd27f9674
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |