Messages in this thread | | | Date | Thu, 23 Nov 2023 13:04:56 -0700 | Subject | Re: [PATCH v3 0/3] nvme link failure fixes | From | Jens Axboe <> |
| |
On 11/22/23 11:25 PM, Arnd Bergmann wrote: > On Thu, Nov 23, 2023, at 02:42, Jens Axboe wrote: >> On 11/22/23 3:47 PM, Arnd Bergmann wrote: >>> From: Arnd Bergmann <arnd@arndb.de> >>> >>> There are still a couple of link failures that I tried to address >>> with a previous patch. I've split up the missing bits into smaller >>> patches and tried to explain the bugs in more detail. >>> >>> With these applied, randconfig builds work again. Please either >>> merge them or treat them as bug reports and find a different fix, >>> I won't do another version. >> >> Applied, but had to hand-apply hunk 9 of patch 3 due to a previous >> attempt at this: >> >> commit 23441536b63677cb2ed9b1637d8ca70315e44bd0 >> Author: Hannes Reinecke <hare@suse.de> >> Date: Tue Nov 14 14:18:21 2023 +0100 >> >> nvme-tcp: only evaluate 'tls' option if TLS is selected > > Ok, thanks for merging my changes! The commit from Hannes > is what I had in my v1 for this, and it was a correct fix > as well, my patch 3/3 was just a more elaborate way to do > the same thing that I did since Hannes did not like my > version at first. > > The 23441536b6 commit was not in linux-next yesterday, so > it looks like our patches crossed paths on the same day.
yeah, it was just recently merged, which is probably why it wasn't there yet and you didn't see it. Not a big deal, easy enough to resolve - just wanted to make sure you knew about it. It should all be heading upstream shortly, just sent out the pull.
-- Jens Axboe
| |