lkml.org 
[lkml]   [2023]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/6] tty: serial: amba-pl011: cleanup driver
On Thu, Nov 23, 2023 at 02:42:41PM +0100, Théo Lebrun wrote:
> Follow recommandations from:
>
> $ ./scripts/checkpatch.pl --strict --file \
> drivers/tty/serial/amba-pl011.c
>
> It does NOT fix alerts relative to TIOCMBIT which will be dealt with in
> another patch. Fixes following alerts:
>
> CHECK: Alignment should match open parenthesis
> CHECK: Blank lines aren't necessary after an open brace '{'
> CHECK: Comparison to NULL could be written [...]
> CHECK: Lines should not end with a '('
> CHECK: Please don't use multiple blank lines
> CHECK: Please use a blank line after function/struct/union/enum declarations
> CHECK: Prefer using the BIT macro
> CHECK: Unbalanced braces around else statement
> CHECK: Unnecessary parentheses around [...]
> CHECK: braces {} should be used on all arms of this statement
> CHECK: spaces preferred around that '/' (ctx:VxV)
> CHECK: spaces preferred around that '|' (ctx:VxV)
> ERROR: do not initialise statics to false
> WARNING: Comparisons should place the constant on the right side of the test
> WARNING: Possible unnecessary 'out of memory' message
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> WARNING: quoted string split across lines
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> drivers/tty/serial/amba-pl011.c | 147 +++++++++++++++++++---------------------
> 1 file changed, 71 insertions(+), 76 deletions(-)

This patch does not apply.

And really, you should have broken it up into smaller pieces and most of
them would have applied :(

Please rebase and break it up and resend.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-11-23 20:37    [W:0.058 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site