lkml.org 
[lkml]   [2023]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 01/12] mm/hugetlb: Export hugetlbfs_pagecache_present()
    You're (thankfully) not actually exporting anything, so please
    don't claim that in the subject.

    > pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma,
    > unsigned long addr, pud_t *pud);
    > +bool hugetlbfs_pagecache_present(struct hstate *h,
    > + struct vm_area_struct *vma,
    > + unsigned long address);

    Can you just follow the much more readable two tab indent of the
    function above?

    > -static bool hugetlbfs_pagecache_present(struct hstate *h,
    > - struct vm_area_struct *vma, unsigned long address)
    > +bool hugetlbfs_pagecache_present(struct hstate *h,
    > + struct vm_area_struct *vma, unsigned long address)

    Same here. The new indentation not only is less readable but also
    creates a pointlessly overlong line.

    \
     
     \ /
      Last update: 2023-11-23 08:23    [W:2.311 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site